Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update charmcraft.yaml parts to use subdirectory for grafana dashboards directory #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wyattrees
Copy link
Contributor

This PR requires canonical/maas-grafana-dashboards#1 to be merged, which splits the dashboards into directories

Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestions. Please take a look for any typo before applying them :)

organize:
"*": src/grafana_dashboards/
maas_stats.json: src/grafana_dashboards/maas_stats.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maas_stats.json: src/grafana_dashboards/maas_stats.json
maas_stats.json: src/grafana_dashboards/maas/maas_stats.json

organize:
"*": src/grafana_dashboards/
maas_stats.json: src/grafana_dashboards/maas_stats.json
prime:
- src/grafana_dashboards/maas_stats.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- src/grafana_dashboards/maas_stats.json
- src/grafana_dashboards/maas/maas_stats.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants