Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix pull request action and various CI issues #15

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

skatsaounis
Copy link
Collaborator

@skatsaounis skatsaounis commented Mar 29, 2024

This PR includes the following:

  • Style fixes and usage of Python 3.8 to be compliant with Observability charm stack
  • Introduce of static tests for both charm and library code to conform to Observability Github actions
  • Re-publishing of the charm library under the proper charm. The existing LIBID was causing 500s on fetch-lib, publish-lib.
  • Implementation of integration tests
  • Usage of lxd as the provider of integration tests.

@skatsaounis skatsaounis force-pushed the update-ci branch 5 times, most recently from 8417611 to 993655a Compare March 29, 2024 14:26
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@skatsaounis skatsaounis force-pushed the update-ci branch 5 times, most recently from 1759c67 to 0644053 Compare March 29, 2024 15:05
@skatsaounis skatsaounis changed the title ci: add lxd provider for integration tests ci: fix pull request action and various CI issues Apr 2, 2024
Copy link
Contributor

@alexsander-souza alexsander-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@skatsaounis skatsaounis merged commit a3dfdd6 into main Apr 2, 2024
24 checks passed
@skatsaounis skatsaounis deleted the update-ci branch April 2, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants