Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fail if the Python part has no scripts #858

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: don't fail if the Python part has no scripts #858

merged 1 commit into from
Sep 26, 2024

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Sep 25, 2024

Fixes #843

  • Have you signed the CLA?

@tigarmo tigarmo force-pushed the work/CRAFT-3383-no-python-shebangs branch from 9ee5599 to 1a7b38f Compare September 25, 2024 18:39
@tigarmo tigarmo force-pushed the work/CRAFT-3383-no-python-shebangs branch from 1a7b38f to 1d1514b Compare September 25, 2024 18:49
@tigarmo tigarmo marked this pull request as ready for review September 25, 2024 19:28
@tigarmo tigarmo merged commit b6e370a into main Sep 26, 2024
10 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3383-no-python-shebangs branch September 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens approved these changes

@lengau lengau lengau approved these changes

@cmatsuoka cmatsuoka Awaiting requested review from cmatsuoka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python plugins fail if no scripts have relevant shebangs
3 participants
@tigarmo @sergiusens @lengau