Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style cleanup #334

Merged
merged 64 commits into from
Oct 26, 2023
Merged

Conversation

jo-mueller
Copy link
Member

@jo-mueller jo-mueller commented Oct 13, 2023

Description

This adds the __all__ keyword to all __init__ files. This makes it possible to import functions like this:

from napari_stress import *

Furthermore: does some more major code style cleanup

Type of Change

  • Code style

How Has This Been Tested?

  • Current tests apply

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #334 (d858555) into main (403b7f2) will increase coverage by 1.85%.
The diff coverage is 71.07%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   83.69%   85.54%   +1.85%     
==========================================
  Files          52       51       -1     
  Lines        9427     9238     -189     
==========================================
+ Hits         7890     7903      +13     
+ Misses       1537     1335     -202     
Files Coverage Δ
src/napari_stress/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_approximation/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_approximation/fit_ellipsoid.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/curvature.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/measurements.py 100.00% <ø> (ø)
...apari_stress/_measurements/temporal_correlation.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/toolbox.py 95.33% <100.00%> (-0.05%) ⬇️
src/napari_stress/_plotting/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_plotting/create_plots.py 95.78% <ø> (-0.05%) ⬇️
... and 27 more

jo-mueller and others added 24 commits October 13, 2023 14:08
jo-mueller and others added 23 commits October 19, 2023 10:12
fixed tests

fixed tests

fixed tests
@jo-mueller jo-mueller changed the title added public functions to __all__ Code style cleanup Oct 19, 2023
@jo-mueller jo-mueller merged commit 63c3c44 into campaslab:main Oct 26, 2023
9 of 10 checks passed
@jo-mueller jo-mueller deleted the add-__all__-to-inits branch October 26, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant