Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't return rescaled image #333

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

jo-mueller
Copy link
Member

Avoid returning the rescaled image from the reconstruction toolbox as it makes the returned data unnecessarily large

Description

It removes the rescaled image from the List[LayerDataTuple of the recontruction function

Type of Change

  • Other: Performance improvement

How Has This Been Tested?

  • Current tests cover this

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This makes the returned data unnecessarily large
@jo-mueller jo-mueller added the enhancement New feature or request label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #333 (49de84a) into main (edfd36b) will decrease coverage by 0.04%.
The diff coverage is 81.85%.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   83.72%   83.69%   -0.04%     
==========================================
  Files          52       52              
  Lines        9420     9427       +7     
==========================================
+ Hits         7887     7890       +3     
- Misses       1533     1537       +4     
Files Coverage Δ
src/napari_stress/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_approximation/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_approximation/fit_ellipsoid.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/__init__.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/curvature.py 100.00% <100.00%> (ø)
.../napari_stress/_measurements/deviation_analysis.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/intensity.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/measurements.py 100.00% <100.00%> (ø)
src/napari_stress/_measurements/stresses.py 100.00% <100.00%> (ø)
...apari_stress/_measurements/temporal_correlation.py 100.00% <100.00%> (ø)
... and 40 more

@jo-mueller jo-mueller merged commit 403b7f2 into campaslab:main Oct 11, 2023
7 of 10 checks passed
@jo-mueller jo-mueller deleted the do-not-return-rescaled-image branch October 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant