-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup ci #9
Setup ci #9
Conversation
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Alex!
|
||
[testenv:lint] | ||
description = lint with pylint | ||
deps = pylint>=2.16.2,<3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you ever end up going down the route of optional deps sets in your pyproject.toml
, you can move all of these deps over there (like in caikit), but certainly no need to do that now. It's just a nicer way to keep all deps info in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Thanks!
Signed-off-by: Alex-Brooks <[email protected]>
This PR is essentially a copy + paste + find replace of @evaline-ju's caikit-nlp PR - Thanks Evaline!
Note that currently the listing score is a bit low, so the fail threshold is 6; this will be brought up to 10 in a future PR