cage: return exit code of primary client #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Aug 18, 2023
|
Overall looks good |
joggee-fr
force-pushed
the
jg/exit-code
branch
from
e51f5a1
to
24a70fc
Compare
Some applications indicate different shutdown conditions by returning specific exit codes. One of these is e.g. Kodi, which returns 64 in case the user chose "Power off" and 66 in case the user chose "Reboot". In order to act on these exit codes, it thus makes sense in some situations to pass them on from the primary client to the caller of Cage. This exit code is only returned if the primary client is the cause of Cage terminating. Co-authored-by: Patrick Steinhardt <[email protected]>
joggee-fr
force-pushed
the
jg/exit-code
branch
from
24a70fc
to
dcd7970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resumes work from @pks-t in PR #170.
Main difference is no option is added, the exit code of the primary client is always returned if Cage terminates due to client exiting.
For example, silly command below now returns exit code 17.
In the other hand, if using the Wayland backend and closing the dedicated window for Cage keeps returning exit code 0 whatever the client return.
Some applications indicate different shutdown conditions by returning specific exit codes. One of these is e.g. Kodi, which returns 64 in case the user chose "Power off" and 66 in case the user chose "Reboot". In order to act on these exit codes, it thus makes sense in some situations to pass them on from the primary client to the caller of Cage.
This exit code is only returned if the primary client is the cause of Cage terminating.