Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data Enhancements for Plots Tab #4994

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

Nelliney
Copy link
Contributor

@Nelliney Nelliney commented Sep 9, 2024

Added a custom attribute type to the combo box and implemented changes to ensure custom data is visible on the graph. Additionally, enabled the option to color by custom data. Note: Custom data can be added when logged in (this was the initial behavior for custom data).
fix cBioPortal/cbioportal#10970 (comment)

Screenshot 2024-09-12 at 09 54 07

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 4336751
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/671126827bfef70008612bad
😎 Deploy Preview https://deploy-preview-4994.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inodb inodb requested a review from gblaih September 12, 2024 14:53
@inodb inodb changed the title Custom data Custom data Enhancements for Plots Tab Sep 12, 2024
@dippindots dippindots self-requested a review September 12, 2024 14:53
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nelliney Overall it looks good to me, great pull request. I just have a few minor comments here.

src/pages/resultsView/ResultsViewPage.tsx Outdated Show resolved Hide resolved
src/shared/components/plots/PlotsTab.tsx Outdated Show resolved Hide resolved
src/shared/components/plots/PlotsTab.tsx Outdated Show resolved Hide resolved
src/shared/components/plots/PlotsTab.tsx Outdated Show resolved Hide resolved
src/shared/components/plots/PlotsTab.tsx Outdated Show resolved Hide resolved
studyIds: this.studyIds.result!,
}
);
const specialAttributes = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gblaih @inodb do you understand this here? why are we adding these hardcoded things here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think these are just special attributes that were already in clinicalAttributes from the store. so this plotClinicalAttributes is just clinicalAttributes without the custom attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gblaih and @Nelliney ! Just talked to @gblaih and he will take a look at changing this a bit to avoid code duplication

@alisman alisman merged commit 15011e0 into cBioPortal:master Oct 17, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom data datatype option in plots tab
5 participants