Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to validate floats in clinical files #58

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

rmadupuri
Copy link
Contributor

The current check if (value[0] in ('>','<')) and value[1:].isdigit(): throws an error if the values are floats. This PR fixes that.

@MatthijsPon MatthijsPon self-assigned this Sep 6, 2024
Copy link
Contributor

@MatthijsPon MatthijsPon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@MatthijsPon MatthijsPon merged commit 5e0f5bc into cBioPortal:main Sep 6, 2024
1 of 2 checks passed
@rmadupuri rmadupuri deleted the update_validator branch September 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants