Fix parsing of functions parameters in template arguments #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to call
parameters
fromtemplateArguments
when a function is found in order to correctly pass its prototype.This solves two issues: the parsing of argument identifiers when present, and the resolution of namespaces.
Example:
Before, parsed as:
with the PR:
Some presets need to be adjusted to parse correctly with this PR (fixing of
std::function
parameters):No changes in other presets.
Not tested: libfreenect2, chilitags,hyperscan, tensorflow, ale, ngraph, qt, skia, videoinput, tritonserver, depthai