-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module: Sharpcradle - Execute .NET assembly from URL in memory #112
base: master
Are you sure you want to change the base?
Conversation
@hackabean so since this is essentially 2/4 of what the |
@byt3bl33d3r Are you happy to change the naming to execute-assembly as local-assembly and sharpcradle as remote-assembly in one module execute-assembly ? |
@hackabean yeah that's perfect, that would be awesome. Thanks! |
…option to execute *.xml and *.csproj Merge branch 'master' of https://github.com/hackabean/SILENTTRINITY
Since both of those use the same arguments structure I did not need to add another option.
Does not support arguments as it is a project. Don't know if I need to make it explicit.
Question: |
'Assembly': { | ||
'Description' : 'Path to assembly', | ||
'Local-Assembly': { | ||
'Description' : 'Path to local assembly', | ||
'Required' : True, | ||
'Value' : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hackabean seems like the tests are failing because there isn't a default value here. Can you take a look at the module tests and set it manually through there?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byt3bl33d3r I added default values and still nothing. Teamserver is loading modules without any errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hackabean no worries, i'll take a look later today.
Cheers
@@ -65,12 +65,12 @@ def payload(self): | |||
elif self.options['Remote-Assemebly']['Value']: | |||
with open('core/teamserver/modules/boo/src/remote-assembly.boo', 'r') as module_src: | |||
src = module_src.read() | |||
src = src.replace('BINARY', str(self.options['RemoteAssemebly']['Value'])) | |||
src = src.replace('BINARY', str(self.options['Remote-Assemebly']['Value'])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assembly* - got an extraneous "e" there
Description and screenshoot:
Also finding a reliable way to parse the arguments might be important as some of those tools require quite a range of syntax(es) that ST might struggle to comprehend.