Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tooltip looks #729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve tooltip looks #729

wants to merge 1 commit into from

Conversation

crudelios
Copy link
Collaborator

Before:

tooltip_before

After:

tooltip_after

bvschaik
bvschaik requested changes Jun 30, 2024
View reviewed changes
Copy link
Owner

@bvschaik bvschaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I missed this PR... Code looks good in general, one safety comment.

src/graphics/text.c
{
*largest_width = 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking largest_width is an optional parameter so it can be null. I know we only use this in one place (the tooltips), but let's be safe and add a null-check around accessing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvschaik bvschaik bvschaik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crudelios @bvschaik