Enable gocritic linter #1000
Merged
Enable gocritic linter #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <[email protected]>
rodaine
approved these changes
Nov 29, 2023
trunk-io bot
referenced
this pull request
in ride-app/payments-service
Jan 13, 2024
… v1.0.3 (#897) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/envoyproxy/protoc-gen-validate](https://togithub.com/envoyproxy/protoc-gen-validate) | `v1.0.2` -> `v1.0.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>envoyproxy/protoc-gen-validate (github.com/envoyproxy/protoc-gen-validate)</summary> ### [`v1.0.3`](https://togithub.com/bufbuild/protoc-gen-validate/releases/tag/v1.0.3) [Compare Source](https://togithub.com/envoyproxy/protoc-gen-validate/compare/v1.0.2...v1.0.3) #### What's Changed - Handle github-actions and pip dependencies by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/908](https://togithub.com/bufbuild/protoc-gen-validate/pull/908) - Update README.md to include new protovalidate releases by [@​elliotmjackson](https://togithub.com/elliotmjackson) in [https://github.com/bufbuild/protoc-gen-validate/pull/922](https://togithub.com/bufbuild/protoc-gen-validate/pull/922) - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/906](https://togithub.com/bufbuild/protoc-gen-validate/pull/906) - Bump golang.org/x/tools from 0.10.0 to 0.12.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/939](https://togithub.com/bufbuild/protoc-gen-validate/pull/939) - Bump golang.org/x/net from 0.11.0 to 0.14.0 in /tests by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/932](https://togithub.com/bufbuild/protoc-gen-validate/pull/932) - Trim the readme down by [@​elliotmjackson](https://togithub.com/elliotmjackson) in [https://github.com/bufbuild/protoc-gen-validate/pull/938](https://togithub.com/bufbuild/protoc-gen-validate/pull/938) - Update tibdex/github-app-token by [@​rubensf](https://togithub.com/rubensf) in [https://github.com/bufbuild/protoc-gen-validate/pull/968](https://togithub.com/bufbuild/protoc-gen-validate/pull/968) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/959](https://togithub.com/bufbuild/protoc-gen-validate/pull/959) - Bump google.protobuf.version from 3.23.3 to 3.24.3 in /java by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/955](https://togithub.com/bufbuild/protoc-gen-validate/pull/955) - Update Go+GHA deps by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/984](https://togithub.com/bufbuild/protoc-gen-validate/pull/984) - Bump java deps by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/985](https://togithub.com/bufbuild/protoc-gen-validate/pull/985) - Setup golangci-lint by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/987](https://togithub.com/bufbuild/protoc-gen-validate/pull/987) - Move PGV documentation back into the root README by [@​nicksnyder](https://togithub.com/nicksnyder) in [https://github.com/bufbuild/protoc-gen-validate/pull/1012](https://togithub.com/bufbuild/protoc-gen-validate/pull/1012) - Group dependabot version updates by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/1024](https://togithub.com/bufbuild/protoc-gen-validate/pull/1024) - Fix dependabot by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/1025](https://togithub.com/bufbuild/protoc-gen-validate/pull/1025) - Bump the go-tests group in /tests with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1030](https://togithub.com/bufbuild/protoc-gen-validate/pull/1030) - Bump the java group in /java with 9 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1028](https://togithub.com/bufbuild/protoc-gen-validate/pull/1028) - Bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1027](https://togithub.com/bufbuild/protoc-gen-validate/pull/1027) - Bump the go group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1026](https://togithub.com/bufbuild/protoc-gen-validate/pull/1026) - Bump the java group in /java with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1032](https://togithub.com/bufbuild/protoc-gen-validate/pull/1032) - Enable gocritic linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/1000](https://togithub.com/bufbuild/protoc-gen-validate/pull/1000) - Fix typos in proto comments by [@​WineChord](https://togithub.com/WineChord) in [https://github.com/bufbuild/protoc-gen-validate/pull/999](https://togithub.com/bufbuild/protoc-gen-validate/pull/999) - Enable unused linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/988](https://togithub.com/bufbuild/protoc-gen-validate/pull/988) - Bump the go group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1033](https://togithub.com/bufbuild/protoc-gen-validate/pull/1033) - Bump the go-tests group in /tests with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1036](https://togithub.com/bufbuild/protoc-gen-validate/pull/1036) - Bump the java group in /java with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1035](https://togithub.com/bufbuild/protoc-gen-validate/pull/1035) - Bump the github-actions group with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1038](https://togithub.com/bufbuild/protoc-gen-validate/pull/1038) - Bump the java group in /java with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1040](https://togithub.com/bufbuild/protoc-gen-validate/pull/1040) - Bump the github-actions group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1041](https://togithub.com/bufbuild/protoc-gen-validate/pull/1041) - Bump the java group in /java with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1047](https://togithub.com/bufbuild/protoc-gen-validate/pull/1047) - Bump the go group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1045](https://togithub.com/bufbuild/protoc-gen-validate/pull/1045) - Bump the go-tests group in /tests with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1046](https://togithub.com/bufbuild/protoc-gen-validate/pull/1046) - Bump the java group in /java with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1049](https://togithub.com/bufbuild/protoc-gen-validate/pull/1049) - Statically build all releases by [@​rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/1052](https://togithub.com/bufbuild/protoc-gen-validate/pull/1052) #### New Contributors - [@​mmorel-35](https://togithub.com/mmorel-35) made their first contribution in [https://github.com/bufbuild/protoc-gen-validate/pull/908](https://togithub.com/bufbuild/protoc-gen-validate/pull/908) - [@​nicksnyder](https://togithub.com/nicksnyder) made their first contribution in [https://github.com/bufbuild/protoc-gen-validate/pull/1012](https://togithub.com/bufbuild/protoc-gen-validate/pull/1012) - [@​WineChord](https://togithub.com/WineChord) made their first contribution in [https://github.com/bufbuild/protoc-gen-validate/pull/999](https://togithub.com/bufbuild/protoc-gen-validate/pull/999) **Full Changelog**: bufbuild/protoc-gen-validate@v1.0.2...v1.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/wallet-service). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthieu MOREL [email protected]