Update default python version #751
Conversation
|
|
||
| LATEST_PKG_PYTHON_VERSION != pkg info -g 'python3*' | cut -d'-' -f1 | sed 's/^python//' | sort -n | tail -n1 | sed -r 's/^([0-9])([0-9]+)/\1.\2/' | ||
| PYTHON ?= python${LATEST_PKG_PYTHON_VERSION} | ||
| pyver= ${PYTHON:S/^python//:S/.//:C/\([0-9]+\)/\1/} |
There was a problem hiding this comment.
given that we already have LATEST_PYTHON_VERSION we can use this directly here
Makefile
Outdated
|
|
||
| LATEST_PKG_PYTHON_VERSION != pkg info -g 'python3*' | cut -d'-' -f1 | sed 's/^python//' | sort -n | tail -n1 | sed -r 's/^([0-9])([0-9]+)/\1.\2/' | ||
| PYTHON ?= python${LATEST_PKG_PYTHON_VERSION} |
There was a problem hiding this comment.
this should still have a fallback, since we use this makefile on Travis, too.
There was a problem hiding this comment.
It is a bit complicated. There are multiple layers of overrides happening here.
PYTHON_VERSION ?= $(TRAVIS_PYTHON_VERSION)
SELECTED_PYTHON_VERSION != if [ "$(PYTHON_VERSION)" != "" ]; then echo $(PYTHON_VERSION); else pkg info -g 'python3*' | cut -d'-' -f1 | sed 's/^python//' | sort -n | tail -n1 | sed -r 's/^([0-9])([0-9]+)/\1.\2/'; fi
PYTHON ?= python${SELECTED_PYTHON_VERSION}
pyver= ${PYTHON:S/^python//:S/.//:C/\([0-9]+\)/\1/}1.) When no PYTHON_VERSION was set, use TRAVIS_PYTHON_VERSION
2.) If neither was set, guess SELECTED_PYTHON_VERSION using pkg info
3.) This all can be overwritten via PYTHON.
4.) Read numeric pyver of whatever version was selected
Pkg is not available on Travis (Linux), but a PYTHON_VERSION env variable is set
gronke
force-pushed
the
chore/update-default-python-version
branch
from
3be5ab5
to
02b3780
Compare
addresses an update of Python Typeshed
gronke
force-pushed
the
chore/update-default-python-version
branch
from
bf2575f
to
2906aa4
Compare
gronke
force-pushed
the
chore/update-default-python-version
branch
from
4d60330
to
cbb3037
Compare
| make PYTHON=python3.8 install | ||
| ``` | ||
|
|
||
| At the current time libioc is not packaged or available in FreeBSD ports. |
There was a problem hiding this comment.
this is not entirely true…
https://www.freshports.org/devel/py-libioc it just… still doesn't have all the right dependencies…
There was a problem hiding this comment.
Well, let's tackle this at a different time. Would you open an Issue as a reminder? 💜
gronke
force-pushed
the
chore/update-default-python-version
branch
from
cbb3037
to
2ff6c52
Compare
gronke
force-pushed
the
chore/update-default-python-version
branch
from
2ff6c52
to
71f058e
Compare
gronke
force-pushed
the
chore/update-default-python-version
branch
from
5637df9
to
eba2847
Compare
addresses #750