Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More optimization #2149

Merged
merged 9 commits into from
Jul 13, 2023
Merged

More optimization #2149

merged 9 commits into from
Jul 13, 2023

Conversation

brucemiller
Copy link
Owner

Given a bit more wisdom about gullet, after #2126, I couldn't resist another session with NYTProf for some optimizing... with some promising improvements. A bit more to come.

…urns Tokens; take advantage of that in Gullet; uniform use of isExpandable method, not property
…than Equals when appropriate); Use it in tight loops in Gullet and TeX.pool; move optimized CSName parsing to ->readCSName; faster \expandafter accomodates chains of \expandafter
@brucemiller brucemiller changed the title [WiP] More optimization More optimization Jul 12, 2023
@brucemiller brucemiller requested a review from dginev July 12, 2023 15:53
@brucemiller
Copy link
Owner Author

OK, I think this is sufficient for this PR. (though there's still more that warrants a separate PR)

lib/LaTeXML/Core/Token.pm Outdated Show resolved Hide resolved
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks encouraging now, thanks.

@brucemiller brucemiller merged commit 43610f7 into master Jul 13, 2023
26 checks passed
@brucemiller brucemiller deleted the more-optimization branch July 13, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants