Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Comment accommodations #2141

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Additional Comment accommodations #2141

merged 3 commits into from
Jul 4, 2023

Conversation

brucemiller
Copy link
Owner

Additional Comment accommodations that should have been in previous batch; already had been tested locally, but accidentally got left out.

@brucemiller brucemiller requested a review from dginev July 4, 2023 05:22
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This kind of situation is a good reminder that we don't test the handling of comment tokens in CI. We could benefit from a special test mode that exercises comments, with a new test.

If/when it fits our development schedule...

@brucemiller
Copy link
Owner Author

Good thing you mentioned it; I had at least one test case I could incorporate, and when I fleshed it out it turned up another corner case! Thanks!

@brucemiller brucemiller merged commit e62089e into master Jul 4, 2023
26 checks passed
@brucemiller brucemiller deleted the more-comments branch July 4, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants