New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #1

Open

paulschreiber wants to merge 3 commits into main from feedback

Collaborator

paulschreiber commented Mar 12, 2024

This game did not work properly:

face cards were not scored correctly (Jack 11, Queen 12, King 13, Ace 14)
the cards drawn were not shown
you can keep drawing cards even when none remain
no winner was every shown

In addition:

the code was inconsistently formatted
it lacked documentation (comments) explaining not only what was done, but why it was done

paulschreiber added 3 commits

March 12, 2024 11:13


          format code with eslint and prettier

10adba5


          clean up logging

5f07e7c


          clean up comments

57573e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet