Update Bioconductor environmental variable #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is documented as "Package code can use this to detect that it's running on a Bioconductor build machine".
|
Nice find! I don't have a lot of experience with bioconductor, so I appreciate the help! I'm not sure where I saw |
|
Hi, I updated the tests and fixed the linting problem as suggested. |
|
@llrs thank you for the very nice contribution! I'll merge this now and will aim to put together a new release shortly. |
briandconnelly
approved these changes
Jun 8, 2024
|
@llrs I may have merged too quickly. If you're interested, feel free to submit another PR that adds yourself as a contributor to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came here after #14 to update on_bioconductor.
I couldn't find the BBS_home variable used in the Bioconductor documentation & configuration.
The change updates the variable to the one currently documented/used:
This variable is documented as "Package code can use this to detect that it's running on a Bioconductor build machine" in the enviromental file of the latest Bioconductor versions: https://github.com/Bioconductor/BBS/blob/134de15c69fa8263abe3923328bb432627455765/3.20/Renviron.bioc#L60-L61
It is also set in the Single package builder (used for submissions to Bioconductor): https://github.com/Bioconductor/packagebuilder/blob/bf98061acd027852ed0b092fd861b6d68644e401/check.Renviron#L43
Note: I haven't redocumented the package as I am directly editing from Github.