Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastani: Bump revision for gcc@9 #1309

Closed
wants to merge 1 commit into from

Conversation

lmrodriguezr
Copy link
Contributor

  • See Update gcc dependencies to gcc@9 #1186

  • Also: compress test data

  • Have you followed the guidelines for contributing?

  • Have you checked that there aren't other open pull requests for the same formula update/change?

  • Have you built your formula locally with brew install --build-from-source FORMULA, where FORMULA is the name of the formula you're submitting?

  • Does your build pass brew audit --strict FORMULA (after doing brew install FORMULA)?


- See brewsci#1186
- Also: compress test data
@lmrodriguezr
Copy link
Contributor Author

The formula didn't explicitly require gcc, so I added the requirement in the on_macos block. I suppose it was chain-required by boost?

In any case, please take a look in case I can implement a better solution.

Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastani does not need to depend on GCC on macOS.

@@ -20,6 +21,7 @@ class Fastani < Formula
uses_from_macos "zlib"

on_macos do
depends_on "gcc@9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on "gcc@9"

fastani uses libomp for OpenMP support in Clang, rather than using GCC, so it does not depend on GCC.
See PR https://github.com/brewsci/homebrew-bio/pull/1088/files
Because of that, this PR is no longer needed.

@sjackman
Copy link
Member

Closing without merging, because fastani uses libomp rather than gcc on macOS, but thanks for this PR all the same for this PR, Luis.

@sjackman sjackman closed this Mar 15, 2021
@lmrodriguezr
Copy link
Contributor Author

The gzip of the input FastA files reduces the installation to ~1/4, do you think it's worth it? I can prepare a separate commit (unless you think it may cause any issues)

@sjackman
Copy link
Member

Sounds great! Thanks, Luis.

@lmrodriguezr lmrodriguezr deleted the fastani branch March 16, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants