Add visible_html to assertions #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @boydm for this library.
I'm aware this has been stable for a while. Just wondering if a change in this direction would be welcome. When asserting against html, dumping the raw body of the response can make it tricky to spot where and why the failure occurred. Also, I'd like to avoid tests to pass if a match was found on some html attribute for example.
The idea would be to provide a way to assert only against the "visible" part of html, using
Floki.text/1.This is a rough spike of the idea. If there is interest in such a change, I'd be happy to polish it as needed and update the docs accordingly.