Skip to content

Commit

Permalink
Fixes batch import logic to save target comments
Browse files Browse the repository at this point in the history
Previously, the source comment (text unit) was systemically copied into the target comment (text unit variant) and that for all imported translations. This seems to be the behavior since day 1 of the TextUnitBatchImporterService, yet it is a bug.

It affects ThirdPartySync and all other batch imports.
  • Loading branch information
aurambaj committed Jul 12, 2023
1 parent 4218a20 commit dc08c45
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ public void testAsyncImportTextUnitsNameOnly() throws InterruptedException {
i++;
assertEquals("TEST2", textUnitDTOsFromSearch.get(i).getName());
assertEquals("TEST2 translation for fr", textUnitDTOsFromSearch.get(i).getTarget());
assertNull(textUnitDTOsFromSearch.get(i).getTarget());
assertNull(textUnitDTOsFromSearch.get(i).getTargetComment());
i++;
assertEquals("TEST3", textUnitDTOsFromSearch.get(i).getName());
Expand Down

0 comments on commit dc08c45

Please sign in to comment.