chore(metadata-sidebar): mock storybook queries for MetadataSidebarRedesign #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpiesiak
force-pushed
the
metadata-mock-queries
branch
from
f42ad3f
to
a3eb1cf
Compare
wpiesiak
force-pushed
the
metadata-mock-queries
branch
from
a3eb1cf
to
ed9972a
Compare
wpiesiak
changed the title
karolinaru
reviewed
Oct 8, 2024
| mockEnterpriseMetadataTemplates, | ||
| mockFileRequest, | ||
| mockMetadataInstances, | ||
| } from './__mocks__/MetadataSidebarRedesignedMocks'; | ||
|
|
||
| const fileIdWithMetadata = global.FILE_ID; |
There was a problem hiding this comment.
shouldn't we import the variable from mock data now or it doesn't matter here?
kajarosz
reviewed
Oct 8, 2024
| mockMetadataInstances, | ||
| } from '../__mocks__/MetadataSidebarRedesignedMocks'; | ||
|
|
||
| const fileIdWithMetadata = fileId; |
There was a problem hiding this comment.
Can't it be named using fileIdWithMetadata when it's defined?
| $type: 'myTemplate-453ffc2f-bf5a-464c-a004-476a4eac20fd', | ||
| $parent: 'file_415542803939', | ||
| $typeVersion: 1, | ||
| $template: 'myTemplate', |
There was a problem hiding this comment.
Shouldn't this be templateKey?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mock API requests data in
MetadataSidebarRedesignstories