Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(threaded-replies): hide reply #3447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(threaded-replies): hide reply #3447

wants to merge 2 commits into from

Conversation

TylerGauntlett
Copy link
Contributor

@TylerGauntlett TylerGauntlett commented Oct 18, 2023 •
edited
Loading

What this does

  • Hides the "Reply" button when the comment is in a resolved state
  • Visually maintains margins/padding when "Reply" button is displayed

Callouts

  • Margins had to be changed around a bit to properly apply bottom margin when the "Reply" button is shown vs hidden

Demo

Screenshot 2023-10-18 at 2 05 40 pm

@TylerGauntlett TylerGauntlett requested a review from a team as a code owner October 18, 2023 18:05
@TylerGauntlett TylerGauntlett changed the title Hide reply feat(threaded-replies): hide reply Oct 18, 2023
mickr
mickr approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@mickr mickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickr mickr mickr approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerGauntlett @mickr