fix(headers): Add support for case-insensitive http response headers (#…

…1327)
box · Feb 12, 2021 · 5ec964e · 5ec964e
1 parent 95dd3f3
commit 5ec964e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 20 deletions.
diff --git a/src/lib/Preview.js b/src/lib/Preview.js
@@ -1467,8 +1467,9 @@ class Preview extends EventEmitter {
 
         // Respect 'Retry-After' header if present, otherwise retry full jitter
         let timeoutMs = Math.random() * (2 ** this.retryCount * MS_IN_S);
-        if (err.headers) {
-            const retryAfterS = parseInt(err.headers.get('Retry-After'), 10);
+        if (err.headers && err.headers.get) {
+            const retryAfter = err.headers.get('retry-after') || err.headers.get('Retry-After');
+            const retryAfterS = parseInt(retryAfter, 10);
             if (!Number.isNaN(retryAfterS)) {
                 timeoutMs = retryAfterS * MS_IN_S;
             }

diff --git a/src/lib/__tests__/Preview-test.js b/src/lib/__tests__/Preview-test.js
@@ -2168,27 +2168,30 @@ describe('lib/Preview', () => {
             expect(stubs.load).toBeCalled();
         });
 
-        test('should retry after length specified in Retry-After header if set', () => {
-            preview.file = {
-                id: '0',
-            };
-            stubs.error.headers = {
-                get: sandbox
-                    .stub()
-                    .withArgs('Retry-After')
-                    .returns(5),
-            };
-            preview.open = true;
-            preview.retryCount = 1;
+        test.each(['retry-after', 'Retry-After'])(
+            'should retry after length specified in %s header if set',
+            retryAfter => {
+                preview.file = {
+                    id: '0',
+                };
+                stubs.error.headers = {
+                    get: sandbox
+                        .stub()
+                        .withArgs(retryAfter)
+                        .returns(5),
+                };
+                preview.open = true;
+                preview.retryCount = 1;
 
-            preview.handleFetchError(stubs.error);
+                preview.handleFetchError(stubs.error);
 
-            jest.advanceTimersByTime(4000);
-            expect(stubs.load).not.toBeCalled();
+                jest.advanceTimersByTime(4000);
+                expect(stubs.load).not.toBeCalled();
 
-            jest.advanceTimersByTime(5001);
-            expect(stubs.load).toBeCalled();
-        });
+                jest.advanceTimersByTime(5001);
+                expect(stubs.load).toBeCalled();
+            },
+        );
     });
 
     describe('triggerError()', () => {