Library changes & Quit fix #2906

RozeFound · 2023-05-26T01:42:48Z

Description

Fix window not remembering size on Ctrl+Q, apparently force quit() is not a close request
Deprecate Gtk.Picture.set_pixbuf before it starts to produce warnings GNOME/gtk@4bede73
Set full application name in "No cover" placeholder in Library View, I thing It'll be more descriptive

Not sure if it fixes any issues tho

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

github-actions · 2023-05-26T01:45:30Z

Pylint result on modfied files:

************* Module bottles.frontend.main
bottles/frontend/main.py:26:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:26:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:27:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:27:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:28:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:28:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:48:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:49:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:51:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:53:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:57:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:62:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:65:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:65:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:84:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:88:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:88:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:88:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:89:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:90:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:90:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:91:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:91:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:92:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:92:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:180:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:180:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:180:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:180:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:203:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:203:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:207:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:207:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:208:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:211:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:211:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:211:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:211:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/main.py:32:0: C0413: Import "from gi.repository import Gtk, Gio, GLib, GObject, Adw" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:32:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/main.py:34:0: W0401: Wildcard import bottles.frontend.params (wildcard-import)
bottles/frontend/main.py:34:0: C0413: Import "from bottles.frontend.params import *" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:35:0: C0413: Import "from bottles.backend.logger import Logger" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:36:0: C0413: Import "from bottles.frontend.windows.main_window import MainWindow" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:37:0: C0413: Import "from bottles.frontend.views.preferences import PreferencesWindow" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:38:0: C0413: Import "from bottles.backend.health import HealthChecker" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:49:0: C0103: Constant name "base_dir" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/frontend/main.py:169:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/main.py:175:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/main.py:179:16: C0103: Variable name "a" doesn't conform to snake_case naming style (invalid-name)
bottles/frontend/main.py:197:12: C0415: Import outside toplevel (bottles.frontend.windows.bottlepicker.BottlePickerDialog) (import-outside-toplevel)
bottles/frontend/main.py:210:8: C0415: Import outside toplevel (subprocess) (import-outside-toplevel)
bottles/frontend/main.py:211:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/frontend/main.py:190:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/frontend/main.py:244:8: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/main.py:237:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:247:15: W0613: Unused argument 'action' (unused-argument)
bottles/frontend/main.py:247:28: W0613: Unused argument 'param' (unused-argument)
bottles/frontend/main.py:255:24: W0613: Unused argument 'action' (unused-argument)
bottles/frontend/main.py:255:37: W0613: Unused argument 'param' (unused-argument)
bottles/frontend/main.py:263:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:267:4: W1113: Keyword argument before variable positional arguments list in the definition of __show_importer_view function (keyword-arg-before-vararg)
bottles/frontend/main.py:267:35: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/main.py:267:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:255:4: W0238: Unused private member `Bottles.__refresh(self, action=None, param=None)` (unused-private-member)
bottles/frontend/main.py:234:8: W0201: Attribute 'win' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/main.py:357:9: W0613: Unused argument 'version' (unused-argument)
bottles/frontend/main.py:20:0: C0411: standard import "import os" should be placed before "import gi" (wrong-import-order)
bottles/frontend/main.py:21:0: C0411: standard import "import gettext" should be placed before "import gi" (wrong-import-order)
bottles/frontend/main.py:22:0: C0411: standard import "import locale" should be placed before "import gi" (wrong-import-order)
bottles/frontend/main.py:23:0: C0411: standard import "import webbrowser" should be placed before "import gi" (wrong-import-order)
bottles/frontend/main.py:24:0: C0411: standard import "from os import path" should be placed before "import gi" (wrong-import-order)
bottles/frontend/main.py:34:0: W0614: Unused import(s) APP_NAME_LOWER, APP_ID, BUILD_TYPE, ANIM_DURATION, EXECUTABLE_EXTS and DOC_URL from wildcard import of bottles.frontend.params (unused-wildcard-import)
************* Module bottles.frontend.widgets.library
bottles/frontend/widgets/library.py:92:32: C0303: Trailing whitespace (trailing-whitespace)
bottles/frontend/widgets/library.py:114:34: W0511: TODO: Remove from list (fixme)
bottles/frontend/widgets/library.py:120:26: W0511: TODO: remove entry from library (fixme)
bottles/frontend/widgets/library.py:34:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:36:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:58:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:71:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:72:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:74:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:77:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:77:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:80:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:81:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:90:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:110:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:110:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:111:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:111:0: W1405: Quote delimiter ' is inconsistent with the rest of the file (inconsistent-quotes)
bottles/frontend/widgets/library.py:67:12: W0719: Raising too general exception: Exception (broad-exception-raised)
bottles/frontend/widgets/library.py:108:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/frontend/widgets/library.py:124:60: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/library.py:142:24: W0613: Unused argument 'result' (unused-argument)
bottles/frontend/widgets/library.py:142:38: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/library.py:159:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/widgets/library.py:162:29: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/library.py:162:37: W0613: Unused argument 'with_terminal' (unused-argument)
bottles/frontend/widgets/library.py:172:24: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/library.py:175:27: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/library.py:181:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/widgets/library.py:185:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/widgets/library.py:191:4: W0221: Number of parameters was 2 in 'Box.hide' and is now 1 in overriding 'LibraryEntry.hide' method (arguments-differ)
bottles/frontend/widgets/library.py:191:4: W0221: Variadics removed in overriding 'LibraryEntry.hide' method (arguments-differ)
bottles/frontend/widgets/library.py:194:4: W0221: Number of parameters was 2 in 'Box.show' and is now 1 in overriding 'LibraryEntry.show' method (arguments-differ)
bottles/frontend/widgets/library.py:194:4: W0221: Variadics removed in overriding 'LibraryEntry.show' method (arguments-differ)
bottles/frontend/widgets/library.py:138:4: W0238: Unused private member `LibraryEntry.__is_alive(self)` (unused-private-member)

RozeFound · 2023-05-26T01:48:05Z

Whoops, I forgot to create new branch before making a PR...

TheEvilSkeleton · 2023-06-06T10:11:01Z

@RozeFound any reason for closing this?

(We're all really busy ATM so we can't review)

RozeFound · 2023-06-06T15:13:47Z

There was no feedback so I thought it's bad structured.
I will divide it in two (Library changes and fix for ctrl+q) or more PR's instead

Kinsteen · 2023-06-06T15:14:32Z

I think it's okay keeping it like this, it's pretty small

RozeFound · 2023-06-06T15:18:55Z

It is small, but changes are unrelated to each other mostly

TheEvilSkeleton · 2023-06-06T17:55:11Z

There was no feedback so I thought it's bad structured.

Ah, sorry for that. Like I said we're just really busy right now

RozeFound · 2023-06-07T13:34:08Z

To be honest I don't know how to separate it without redoing changes...
So I hope you're okay with this PR 😅

TheEvilSkeleton · 2023-06-08T12:34:46Z

To be honest I don't know how to separate it without redoing changes... So I hope you're okay with this PR sweat_smile

You can use git rebase to restructure the commit history, but it's tedious to work with and gets annoying for every change. I can squash the commit, which shouldn't be a big deal.

RozeFound · 2023-06-08T12:48:48Z

Thanks! I'm pretty bad with git so it'll be a pleasure from your side

RozeFound · 2023-06-08T12:50:12Z

And I haven't tested it yet, so it might just not work 😅
I guess if I plan to continue contributing to Bottles, I have to create some kind of testing or, better, development environment

TheEvilSkeleton · 2023-06-08T13:01:32Z

What a coincidence, I opened #2921 because I noticed that some information/tools are redundant or outdated for our use case, so I went ahead to create a meta-issue :D

mirkobrombin · 2023-08-05T11:34:49Z

Tested and everything works as expected. Merging when the CI finish if there are no conflicts.

koplo199 · 2023-09-14T09:07:42Z

This PR needs to be rebased to trigger the missing SonarQube Code Analysis checks. Could it eventually be merged after that?

fab-sonarqube · 2023-09-14T16:30:06Z

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

RozeFound and others added 11 commits March 24, 2023 06:02

Fix label_no_cover not being used

3d63c22

Center grid items in library

cfaf09a

Properly center view

f90e0d9

move comment

b1bc424

Fix items_per_line not updating

d834280

Adapt view on entry removal

f4875c3

Merge branch 'bottlesdevs:main' into main

dfafb33

Fix window not remembering size on Ctrl+Q

88d4742

Gtk.Picture.set_pixbuf deprecation

7f80a18

Remove unused import

2007a09

Set full application name for "No cover" placeholder

50bc2a6

RozeFound added 3 commits May 26, 2023 09:51

Wrap full name in "no cover"

84e56d4

Load cover asynchronimously

15d7a26

Use Gdk.Texture

9306528

RozeFound closed this Jun 6, 2023

GTK is not thread-safe

389bfda

RozeFound reopened this Jun 7, 2023

RozeFound added 3 commits June 7, 2023 20:34

Merge branch 'main' into main

3a07594

__quit is no longer staticmethod

24efddf

Remove whitespace

21e9889

RozeFound changed the title ~~Yet another bunch of little changes~~ Library changes & Quit fix Jun 7, 2023

TheEvilSkeleton added this to the 52.0 milestone Jun 8, 2023

Merge branch 'main' into main

b329a79

TheEvilSkeleton and others added 2 commits July 29, 2023 16:40

Merge branch 'main' into main

4256164

Merge branch 'main' into main

d9beb71

Merge branch 'main' into main

96f0ce2

orowith2os merged commit b6eb91a into bottlesdevs:main Sep 14, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Library changes & Quit fix #2906

Library changes & Quit fix #2906

RozeFound commented May 26, 2023 •

edited

Loading

github-actions bot commented May 26, 2023 •

edited

Loading

RozeFound commented May 26, 2023

TheEvilSkeleton commented Jun 6, 2023 •

edited

Loading

RozeFound commented Jun 6, 2023

Kinsteen commented Jun 6, 2023

RozeFound commented Jun 6, 2023

TheEvilSkeleton commented Jun 6, 2023

RozeFound commented Jun 7, 2023

TheEvilSkeleton commented Jun 8, 2023 •

edited

Loading

RozeFound commented Jun 8, 2023

RozeFound commented Jun 8, 2023 •

edited

Loading

TheEvilSkeleton commented Jun 8, 2023

mirkobrombin commented Aug 5, 2023 •

edited

Loading

koplo199 commented Sep 14, 2023

fab-sonarqube bot commented Sep 14, 2023

Library changes & Quit fix #2906

Library changes & Quit fix #2906

Conversation

RozeFound commented May 26, 2023 • edited Loading

Description

Type of change

github-actions bot commented May 26, 2023 • edited Loading

RozeFound commented May 26, 2023

TheEvilSkeleton commented Jun 6, 2023 • edited Loading

RozeFound commented Jun 6, 2023

Kinsteen commented Jun 6, 2023

RozeFound commented Jun 6, 2023

TheEvilSkeleton commented Jun 6, 2023

RozeFound commented Jun 7, 2023

TheEvilSkeleton commented Jun 8, 2023 • edited Loading

RozeFound commented Jun 8, 2023

RozeFound commented Jun 8, 2023 • edited Loading

TheEvilSkeleton commented Jun 8, 2023

mirkobrombin commented Aug 5, 2023 • edited Loading

koplo199 commented Sep 14, 2023

fab-sonarqube bot commented Sep 14, 2023

RozeFound commented May 26, 2023 •

edited

Loading

github-actions bot commented May 26, 2023 •

edited

Loading

TheEvilSkeleton commented Jun 6, 2023 •

edited

Loading

TheEvilSkeleton commented Jun 8, 2023 •

edited

Loading

RozeFound commented Jun 8, 2023 •

edited

Loading

mirkobrombin commented Aug 5, 2023 •

edited

Loading