Skip HEAD for multipart check when multipart_threshold is 0 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveisfera
force-pushed
the
disable_download_head
branch
from
85d2f68
to
7f69e3a
Compare
|
Changed to |
daveisfera
force-pushed
the
disable_download_head
branch
from
7f69e3a
to
4f27bcf
Compare
daveisfera
force-pushed
the
disable_download_head
branch
from
4f27bcf
to
e63993b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each download does a
HEADbefore theGET, but unless the file is possible a very large file that would benefit from multipart download, then this is just adding unneeded operations and delay. This PR changes it so thatmultipart_thresholdbeing 0 will skip theHEADcall and I'd argue that this should be the changed to the default behavior as wellRelated to boto/boto3#3083