-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cmake support to examples #1313
feat: add cmake support to examples #1313
Conversation
9017ee3
to
f5f48cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, and modernization! Thanks!
I have only a question. Also it seems that something is missing and some examples cannot be compiled in CI.
- replace BOOST_FOREACH - replace Boost.Assign - replace typedef with using - other minor changes
Indeed, will handle. Thanks. |
f5f48cb
to
68bcb25
Compare
✅ |
68bcb25
to
4677048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, now all examples (except from problematic ones where comments are inserted) are included and the test are passing.
replace BOOST_FOREACH
replace Boost.Assign
replace typedef with using
other minor changes