Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] complete cmake coverage #1286

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

barendgehrels
Copy link
Collaborator

@barendgehrels barendgehrels commented May 22, 2024

This makes CMake coverage complete for unit tests.
The CMakeLists are generated automatically, and manually edited where indicated.
There is one test added to the Jam suite as well, as indicated.

@barendgehrels barendgehrels self-assigned this May 22, 2024
boost_geometry_add_unit_test("formulas" ${item})
endforeach()

if (NOT APPLE)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual edit

boost_tuple
box
custom_linestring
# initialization
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two commented tests would need extra dependencies (for test only).

@@ -13,5 +13,6 @@
# Version 1.0. (See accompanying file LICENSE_1_0.txt or copy at
# http://www.boost.org/LICENSE_1_0.txt)

build-project wkt ;
build-project dsv ;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dsv Jamfile was there, but not run. For CMake it runs without problems - so I added it for Jam too

closing_iterator
# concatenate_iterator
ever_circling_iterator
# flatten_iterator
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two manual edits, needing extra dependencies

reversible_view
segment_view
)
boost_geometry_add_unit_test("views" ${item})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format change only

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it is great to have full cmake support.

There is also a related cmake issue #1282 but that could be handled in different PR.

@vissarion vissarion added this to the 1.86 milestone May 30, 2024
@vissarion vissarion merged commit 6b76894 into boostorg:develop Jul 24, 2024
23 checks passed
@vissarion vissarion modified the milestones: 1.86, 1.87 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants