Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): support new linked applications model #355

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

akantcheff
Copy link
Contributor

@akantcheff akantcheff commented May 31, 2024

This PR aims to support the incoming feature of linked applications.

This new model uses OpenAPI inheritance and unfortunately the OpenAPI Generator does not support inheritance for the moment.

We expect both AdvancedApplication and LegacyApplication classes to extend AbstractApplication class and to implement the Application interface, but it does not: all are independent classes.
So for the moment we ignore the class AbstractApplication while inheritance is still not supported. The class Application is used to handle both advanced and legacy applications for some common routes. Some routes are exclusively for legacy applications and the LegacyApplication class is used. AdvancedApplication is generated but not used by API classes.

The class ApplicationApi is no longer ignored by the OpenAPI Generator and comes with breaking changes. Meaning that we need to release a major version 2.0.0 after this PR.


⚠️ This PR is still in progress
TODO:

  • Wait for fix(get-application-page): incorrect content type bonita-openapi#173 to be merged (for info I update the spec with the maven command and apply manually the changes from the PR)
  • Release new version of openapi
  • Update spec with new version
  • Create tests that is able to handle applications prior 10.2 and after 10.2
  • Use bonita docker image from JFrog
  • Login to JFrog in github actions

@akantcheff akantcheff added enhancement New feature or request WIP Work in progress labels May 31, 2024
@rbioteau rbioteau self-assigned this Jun 25, 2024
@rbioteau rbioteau force-pushed the feat/generate-advanced-applications-model branch from b815da0 to 5073714 Compare June 25, 2024 08:47
adapt tests to run on several Bonita versions
@rbioteau rbioteau force-pushed the feat/generate-advanced-applications-model branch from 5073714 to 73e1b5b Compare June 25, 2024 09:34
@rbioteau rbioteau changed the title feat(codegen): support new advanced applications model feat(codegen): support new linked applications model Jun 25, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rbioteau rbioteau marked this pull request as ready for review June 25, 2024 09:43
@rbioteau rbioteau removed the WIP Work in progress label Jun 25, 2024
@rbioteau rbioteau merged commit f293517 into dev Jun 25, 2024
13 checks passed
@rbioteau rbioteau deleted the feat/generate-advanced-applications-model branch June 25, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants