This repository has been archived by the owner on May 27, 2022. It is now read-only.
Allow whitespace lines in cells. #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Whitespace was handled, a really empty line was not.) Address bollwyvl#22.
|
The change in a19d27b is more elegant, in my opinion, but causes a minor-but-significant issue with whitespace handling itself. The empty string is considered to be a member of all other strings, which means that an empty line causes a line magic evaluation. For a reason that I wasn't able to trace properly, this means that empty lines at the end of a cell will cause the last non-empty line to throw a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22.
The crash was due to a check for
line[0] in "!%". Checking that the line has something in it fixes the issue.Whitespace lines are not included in the stack trace for errors. For obvious reasons, I have no way to see if this is a regression. Based on the fact that comment lines do not show up in said stack trace with or without my patch, my guess is that it is not.