Test against latest Ruby and Rails #326
Conversation
zhuravel
commented
Sep 4, 2024
zhuravel
commented
- Add Ruby 3.3 to test matrix, remove Ruby 3.0 and 3.1
- Add Rails 7.1 and 7.2 to test matrix, remove Rails 6.0 and drop support for Rails 6.0
- Use Appraisal to generate gemfiles with different dependencies
| @@ -0,0 +1,37 @@ | |||
| # Contributing to Datagrid | |||
There was a problem hiding this comment.
Is this file somehow reachable from github UI? If not, I think it is better to make it a paragraph in Readme or at least link it from there.
There was a problem hiding this comment.
The guidelines should be visible when creating an issue or pull request:
https://github.blog/news-insights/contributing-guidelines/#contributors-wanted-inquire-within
CONTRIBUTING.md is commonly used to keep the README concise, which is why I created it separately. However, I’ll go ahead and add a link to CONTRIBUTING.md in the README to make it more accessible.
| name: 'Ruby ${{ matrix.ruby-version }}, Rails ${{ matrix.rails-version }}' | ||
| # To keep matrix size down, only test highest and lowest rubies. | ||
| ruby: ["2.7", "3.3"] | ||
| rails: ["6.1", "7.0", "7.1", "7.2"] |
There was a problem hiding this comment.
Was there any particular reason to drop 6.0 support?
There was a problem hiding this comment.
I’ve removed support for Rails 6.0 as tests are failing on this version. Although the test build was showing as green, it was actually running on Rails 6.1 instead of 6.0. This happened because the Gemfile used ~> 6.0, which incorrectly installed Rails 6.1. To truly use Rails 6.0, the Gemfile should have specified ~> 6.0.0.
I chose not to reintroduce these hacks, and instead, I believe it’s time to officially drop support for this long end-of-life Rails version.
Here’s a screenshot for reference:
