Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallow "index out of range" error #209

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

funkypierre
Copy link

Personal response to #205

Our clients are importing a lot of PDFs, so we needed a workaround for these "malformed" files.
This quick fix is working for us, but feel free to inform me of any trouble it could cause in the future.

Not expecting you to merge it as well, I just wanted to propose this solution for people in the same context.

BigBigDoudou and others added 2 commits June 20, 2023 11:24
* introduce raise_on_encrypted option

* add some detail to the exception

* update the README to specify the raise_on_encrypted option

* 🔪 the CombinePDF.encrypted? method that is no longer needed

* apply patch from @kimyu92

* add guards

* docs + cleanup

* fix release date in changelog

* Adds Github Actions workflow for tests

- Allows us to test the gem on multiple versions of Ruby

---------

Co-authored-by: Levi Wilson <[email protected]>
Co-authored-by: Bo <[email protected]>
Co-authored-by: David Wessman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants