Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Duration types to use a FiniteF64 instead of f64 primitive. #86

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Update Duration types to use a FiniteF64 instead of f64 primitive. #86

merged 3 commits into from
Jul 21, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 19, 2024 •
edited
Loading

This PR updates Duration types to have FiniteF64 fields instead of just a f64.

I still have to re-implement a PartialDurationRecords struct but thought I'd post this as a draft in the meantime for feedback/thoughts.

Also, FiniteF64 probably shouldn't live in utils, but I wasn't sure exactly where to move it... maybe a primitives mod?

@nekevss nekevss added C-api Changes related to the public API C-internal Internal library improvements labels Jul 19, 2024
@nekevss nekevss marked this pull request as ready for review July 19, 2024 23:59
jedel1043
jedel1043 reviewed Jul 20, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liking the new type!

src/components/duration/time.rs Outdated Show resolved Hide resolved
src/components/duration.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
jedel1043
jedel1043 approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a rebase.

@nekevss nekevss merged commit d43b706 into main Jul 21, 2024
5 checks passed
@nekevss nekevss deleted the update-duration-repr branch July 21, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
C-api Changes related to the public API C-internal Internal library improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekevss @jedel1043