Add blank and negated + small adjustments #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
reviewed
Feb 8, 2024
src/components/duration.rs
Outdated
Comment on lines
867
to
870
| /// Returns whether the current `Duration` is blank. | ||
| pub fn blank(&self) -> bool { | ||
| duration_sign(&self.iter().collect()) == 0 | ||
| } |
There was a problem hiding this comment.
Would probably be better to name this is_zero, I think.
There was a problem hiding this comment.
I was more talking about the function itself, since duration_sign returns zero only when self is zero.
There was a problem hiding this comment.
Oh, I'm blind lol yeah, that can work too.
There was a problem hiding this comment.
Glancing back through old temporal meeting minutes. It used to be called isZero but was opted off of, but I see no reason to not go with isZero as long as the equivalency is noted.
There was a problem hiding this comment.
Yeah, blank is not very descriptive IMHO. We can add some comments when we rename spec methods just like in Boa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11
Primarily implementing
blankandnegatedfunctionality onto blank.Renames:
duration_sign->sign