Allow dead code for code that is newly detected as unused #3984
+115
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
==========================================
+ Coverage 47.24% 51.32% +4.08%
==========================================
Files 476 468 -8
Lines 46892 45212 -1680
==========================================
+ Hits 22154 23205 +1051
+ Misses 24738 22007 -2731 ☔ View full report in Codecov by Sentry. |
|
Added #3985 to see if CI is unstuck. |
jedel1043
approved these changes
Sep 6, 2024
HalidOdat
approved these changes
Sep 7, 2024
jedel1043
added a commit
that referenced
this pull request
Sep 8, 2024
* Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <[email protected]> Co-authored-by: José Julián Espina <[email protected]>
jedel1043
added a commit
that referenced
this pull request
Sep 8, 2024
* Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <[email protected]> Co-authored-by: José Julián Espina <[email protected]>
jedel1043
added a commit
that referenced
this pull request
Sep 8, 2024
* Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <[email protected]> Co-authored-by: José Julián Espina <[email protected]>
jedel1043
added a commit
that referenced
this pull request
Sep 11, 2024
* Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <[email protected]> Co-authored-by: José Julián Espina <[email protected]>
raskad
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Implement new spec changes for `AsyncGenerator` (#3950) * Implement new spec changes for `AsyncGenerator` * Add panic docs * Add spec edition 15 to the tester (#3957) * Allow dead code for code that is newly detected as unused (#3984) * Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <[email protected]> Co-authored-by: José Julián Espina <[email protected]> * Enable CI for release branches (#3987) * Allow warnings when running CI on release branches (#3990) * Bump crates version --------- Co-authored-by: Hans Larsen <[email protected]> Co-authored-by: Theo Paris <[email protected]>
hansl
added a commit
to hansl/boa
that referenced
this pull request
Sep 12, 2024
* Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <[email protected]> Co-authored-by: José Julián Espina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear if it is actually unused (
ConstructorNoProtoseems like it is fully unused, but notConstructor). Trying to create an MRE for a rust-lang issue, but couldn't reproduce outside of this repro.This at least temporarily to unblock CI.
Closes #3985.