lazy builtins #3973
Draft
lazy builtins #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jedel1043
reviewed
Aug 29, 2024
jasonwilliams
force-pushed
the
lazy-part-2
branch
from
1c4cc00
to
c52c687
Compare
jedel1043
reviewed
Sep 15, 2024
Comment on lines
-390
to
-399
| let function = object | ||
| .downcast_mut::<NativeFunctionObject>() | ||
| .expect("Builtin must be a function object"); | ||
| function.f = NativeFunction::from_fn_ptr(self.function); | ||
| function.constructor = Some(ConstructorKind::Base); | ||
| function.realm = Some(self.realm.clone()); |
There was a problem hiding this comment.
Oops, I suggested to remove this, but I think this is still needed.
There was a problem hiding this comment.
I've made some updates to this, take a look
jedel1043
reviewed
Sep 15, 2024
|
|
||
| #[derive(Debug, Clone, Trace, Finalize)] | ||
| pub(crate) enum BuiltinKind { | ||
| Function(JsFunction), |
There was a problem hiding this comment.
Hmm, thinking a bit more about this, I think Function should store a NativeFunctionObject instead, and the builder methods should be adjusted to consider this. Else, the builder won't set the builtin to the correct value while initializing.
Handle toString for lazyBuiltIn objects
jasonwilliams
force-pushed
the
lazy-part-2
branch
from
cf4a379
to
d697af1
Compare
jedel1043
reviewed
Oct 6, 2024
Comment on lines
+95
to
+101
| if builtin.borrow().data.init_and_realm.is_some() { | ||
| let mut builtin_borrow = builtin.borrow_mut(); | ||
| let (init, realm_inner) = builtin_borrow | ||
| .data | ||
| .init_and_realm | ||
| .take() | ||
| .expect("init_and_realm not set"); |
There was a problem hiding this comment.
With the new changes this can be improved. Instead of calling init_and_realm.is_some(), then init_and_realm.take(), we can do if let Some(data) = builtin.borrow_mut().data.init_and_realm.take()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy Builtins