Add two parsers #67
Merged
Add two parsers #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhslepicka
reviewed
Jul 1, 2023
pytao/interface_commands.py
Outdated
| @@ -2380,6 +2380,63 @@ def tao_global(tao, *, verbose=False, as_dict=True, raises=True): | |||
| return __execute(tao, cmd, as_dict, raises, method_name='tao_global', cmd_type='string_list') | |||
|
|
|||
|
|
|||
| def global_optimation(tao, *, verbose=False, as_dict=True, raises=True): | |||
There was a problem hiding this comment.
Is the method name correct? Maybe global_optimization?
There was a problem hiding this comment.
Looks like this is a new command:
tao.global_optimation()
{'CR': 0.800000011920929,
'F': 0.800000011920929,
'l_best': 0.0,
'binomial_cross': False,
'use_2nd_diff': False,
'randomize_F': False,
'minimize_merit': True}
| return __execute(tao, cmd, as_dict, raises, method_name='global_optimation', cmd_type='string_list') | ||
|
|
||
|
|
||
| def global_opti_de(tao, *, verbose=False, as_dict=True, raises=True): |
There was a problem hiding this comment.
This seems to be the same as above
There was a problem hiding this comment.
Hmm, that's giving the same as above.
There was a problem hiding this comment.
Okay, I found it. There were typos in tao/tao_python_cmd.f90.
hhslepicka
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds special parsers for:
Tao.meritTao.ele_control_var