Refactors pulled from #668 #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
force-pushed
the
cleanup-prep
branch
from
0e65ba8
to
d99c079
Compare
There was a problem hiding this comment.
Looks good. Most of the differences from #668 are union-specific files. The rest are mostly related to structures.container.ContainerStructure
Then there are some remaining differences that I'll highlight in a PR to your PR branch.
|
CI failures arise from a dask release. Fix in 52ec6b8. |
|
Hm, more breakage from dask here: https://github.com/bluesky/tiled/actions/runs/8249730000/job/22562754120#step:10:796 |
danielballan
force-pushed
the
cleanup-prep
branch
from
2f1631c
to
f70d418
Compare
|
The breakage from dask 2024-3 is substantial. We can't address this quickly, correctly, so I have pinned back dask in a separate PR, merged by @tacaswell. This PR has been rebased on that and should now pass CI 🤞 . |
padraic-shafer
approved these changes
Mar 12, 2024
hyperrealist
pushed a commit
to hyperrealist/tiled
that referenced
this pull request
Mar 18, 2024
* Sort enum members. * Move structure_family to the end, matching migration result. * Sort * Only set include_data_sources param if not default (false). * Refactor link-writing into separate module. * Refactor structure family check into dependency * remove server.core.FULL_LINKS * Clarify default data_sources for CatalogNodeAdapter * Add structure_families to dependency check for put '/[node|table]/full' * Create node uses structure_family of data_source * Be robust against __doc__ being None. * Use dask.dataframe.core, not new dask-expr. --------- Co-authored-by: Padraic Shafer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted some refactor / cleanup commits from #668. We can base the items on the critical path for flyscanning (appendable tables and update-able data sources) on this while we take our time working through the design considerations in #668.