Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: release notes for v1.8.0 #1127

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

mrakitin
Copy link
Member

Here are the relevant updates which will be added to the release description (auto-generated by GitHub).

What's Changed

New Contributors

Full Changelog: v1.7.0...v1.8.0

@coretl
Copy link
Collaborator

coretl commented Jun 23, 2023

Hmm, docs aren't building, I'll take a look

@coretl
Copy link
Collaborator

coretl commented Jun 23, 2023

Looks like latest event-model is incompatible with ophyd, fix here: bluesky/event-model#275

Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new release of event model sorted the problem, so I think this is good to go

@mrakitin
Copy link
Member Author

@coretl, thanks for your review and help with resolving the CI issues!

@prjemian, do you have any feedback on this PR?

@prjemian
Copy link
Contributor

Aack! My feedback is that we missed a typo in PR #1055:

"PvcamDetectorCam",
"PvcamDetectorCam",

Line 44 should read PvaDetectorCam as written here:

class PvaDetectorCam(CamBase):

@prjemian
Copy link
Contributor

I'll push that through in a new PR.

@prjemian prjemian mentioned this pull request Jun 26, 2023
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrakitin mrakitin merged commit 1c8487b into bluesky:master Jun 26, 2023
8 checks passed
@mrakitin mrakitin deleted the rel-notes-v1.8.0 branch June 26, 2023 18:50
@mrakitin
Copy link
Member Author

The release is out, thanks all!
https://pypi.org/project/ophyd/1.8.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants