Merge pull request #1099 from tizayi/master

BUG: isinstance calls property success before status object is done

ophyd/v2/core.py

@@ -81,7 +81,9 @@ def done(self) -> bool:
 
     @property
     def success(self) -> bool:
-        assert self.done, "Status has not completed yet"
+        if not self.done:
+            return False
+
         try:
             self.task.result()
         except (Exception, asyncio.CancelledError):

ophyd/v2/tests/test_core.py

@@ -1,8 +1,10 @@
+import asyncio
 import re
 
 import pytest
+from bluesky.protocols import Status
 
-from ophyd.v2.core import Signal
+from ophyd.v2.core import AsyncStatus, Signal
 
 
 class MySignal(Signal):
@@ -29,3 +31,13 @@ def test_signals_equality_raises():
         match=re.escape("'>' not supported between instances of 'MySignal' and 'int'"),
     ):
         s1 > 4
+
+
+async def test_async_status_success():
+    st = AsyncStatus(asyncio.sleep(0.1))
+    assert isinstance(st, Status)
+    assert not st.done
+    assert not st.success
+    await st
+    assert st.done
+    assert st.success