-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added number_of_frames instead of iterations #581
base: main
Are you sure you want to change the base?
Conversation
d86e04c
to
c52e34b
Compare
e7c72ba
to
31c7ded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can we have a test that looks like the tomography example?
] | ||
|
||
|
||
async def test_hdf_panda_hardware_triggered_flyable_with_iterations( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted test_hdf_panda_hardware_triggered_flyable_with_iterations
and moved it to
@pytest.mark.parametrize("number_of_frames", [[1, 1, 1, 1], [2, 3, 100, 3]])
async def test_hardware_triggered_flyable(
As we are removing iterations
fb3343e
to
3a56af0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, I think we should wait for a once over from @coretl before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed my mind, I'd quite like
Which means either:
1)
adding
self._frames_completed += 1
to complete
and removing
self._frames_completed += self._frames_to_complete
from kickoff
.
Or (and I actually think this is the nicer option)
2)
Changing its name to self._completable_frames
and leaving a comment in init
that it represents the total number of frames that will have been completed at the end of the next complete
.
This is nicer because it means that
if self._completable_frames >= self._trigger_info.total_number_of_triggers:
raise RuntimeError(
will still work - if we changed to increment by 1 then would probably still need this variable to make sure you can't kickoff
too many times.
closes #575