ENH: Added NX_class as a PerObjectHint to the event descriptor. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is an optional hint that can be used to carry a NeXus class definition one may wish to associate with a device.
danielballan
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
This looks good to me, but @evalott100 should sign off before we merge, to confirm that there's nothing special we have to do with schema generation here.
CI does our generation check! LGTM 🙏 |
evalott100
approved these changes
Aug 22, 2024
|
Nice to have a @burkeds commit in event-model. Thanks Devin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional hint that can be used to carry a NeXus class definition one may wish to associate with a device.
Motivation and Context
It would be good to have a standard way to assign a NeXus class definition to a high level device. Having a specific field with a standard name will better allow the community to converge on a standard way to assign and use this definition for high level processes such as writing callbacks.