Add alg argument #2869
Closed
Add alg argument #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this shouldn't be necessary in backend/Node environment, jose seems to use its browser package if you are trying to use this in Bun. The added argument here will be ignored in proper node environments, but also makes it work in Bun. Clue here: panva/jose#471
matthieusieben
requested changes
Oct 12, 2024
| @@ -40,7 +40,7 @@ export class JoseKey extends Key { | |||
|
|
|||
| protected async getKey() { | |||
| try { | |||
| return (this.#keyObj ||= await importJWK(this.jwk as JWK)) | |||
| return (this.#keyObj ||= await importJWK(this.jwk as JWK, "ES256")) | |||
There was a problem hiding this comment.
The key alg might not be ES256 here (though in practice, when used from @atproto/oauth-*, it probably will always be)
|
Covered by: #2879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this shouldn't be necessary in backend/Node environment, jose seems to use its browser package if you are trying to use this in Bun. The added argument here will be ignored in proper node environments, but also makes it work in Bun. Clue here: panva/jose#471