Remove default value for post table invalid attrs (#1601)

remove default value for post table attrs
bluesky-social · Sep 14, 2023 · 79867d2 · 79867d2
1 parent cf6002a
commit 79867d2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/packages/bsky/src/db/migrations/20230906T222220386Z-thread-gating.ts b/packages/bsky/src/db/migrations/20230906T222220386Z-thread-gating.ts
@@ -12,15 +12,11 @@ export async function up(db: Kysely<unknown>): Promise<void> {
     .execute()
   await db.schema
     .alterTable('post')
-    .addColumn('invalidReplyRoot', 'boolean', (col) =>
-      col.notNull().defaultTo(false),
-    )
+    .addColumn('invalidReplyRoot', 'boolean')
     .execute()
   await db.schema
     .alterTable('post')
-    .addColumn('violatesThreadGate', 'boolean', (col) =>
-      col.notNull().defaultTo(false),
-    )
+    .addColumn('violatesThreadGate', 'boolean')
     .execute()
 }
 

diff --git a/packages/bsky/src/db/tables/post.ts b/packages/bsky/src/db/tables/post.ts
@@ -1,4 +1,4 @@
-import { Generated, GeneratedAlways } from 'kysely'
+import { GeneratedAlways } from 'kysely'
 
 export const tableName = 'post'
 
@@ -12,8 +12,8 @@ export interface Post {
   replyParent: string | null
   replyParentCid: string | null
   langs: string[] | null
-  invalidReplyRoot: Generated<boolean>
-  violatesThreadGate: Generated<boolean>
+  invalidReplyRoot: boolean | null
+  violatesThreadGate: boolean | null
   createdAt: string
   indexedAt: string
   sortAt: GeneratedAlways<string>

diff --git a/packages/bsky/src/services/feed/index.ts b/packages/bsky/src/services/feed/index.ts
@@ -166,7 +166,13 @@ export class FeedService {
     return posts.reduce((acc, cur) => {
       const { recordJson, ...post } = cur
       const record = jsonStringToLex(recordJson) as PostRecord
-      const info: PostInfo = { ...post, record, viewer }
+      const info: PostInfo = {
+        ...post,
+        invalidReplyRoot: post.invalidReplyRoot ?? false,
+        violatesThreadGate: post.violatesThreadGate ?? false,
+        record,
+        viewer,
+      }
       return Object.assign(acc, { [post.uri]: info })
     }, {} as PostInfoMap)
   }