Perform pessimistic handle check when updating handle (#1300)

perform pessimistic handle check when updating handle
bluesky-social · Jul 7, 2023 · 2e52f38 · 2e52f38
1 parent 08dc2b7
commit 2e52f38
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/pds/src/api/com/atproto/identity/updateHandle.ts b/packages/pds/src/api/com/atproto/identity/updateHandle.ts
@@ -47,6 +47,14 @@ export default function (server: Server, ctx: AppContext) {
         }
       }
 
+      // Pessimistic check to handle spam: also enforced by updateHandle() and the db.
+      const available = await ctx.services
+        .account(ctx.db)
+        .isHandleAvailable(handle)
+      if (!available) {
+        throw new InvalidRequestError(`Handle already taken: ${handle}`)
+      }
+
       const seqHandleTok = await ctx.db.transaction(async (dbTxn) => {
         let tok: HandleSequenceToken
         try {

diff --git a/packages/pds/src/services/account/index.ts b/packages/pds/src/services/account/index.ts
@@ -160,6 +160,7 @@ export class AccountService {
       .set({ handle })
       .where('did', '=', did)
       .whereNotExists(
+        // @NOTE see also condition in isHandleAvailable()
         this.db.db
           .selectFrom('did_handle')
           .where('handle', '=', handle)
@@ -178,6 +179,16 @@ export class AccountService {
     await sequencer.sequenceEvt(this.db, seqEvt)
   }
 
+  async isHandleAvailable(handle: string) {
+    // @NOTE see also condition in updateHandle()
+    const found = await this.db.db
+      .selectFrom('did_handle')
+      .where('handle', '=', handle)
+      .select('handle')
+      .executeTakeFirst()
+    return !found
+  }
+
   async updateEmail(did: string, email: string) {
     await this.db.db
       .updateTable('user_account')