fix chroma_format_idc value for baseline profile

[hsnks100]

There is a bug in sps in h.264 base, main, and extended that does not provide accurate values when estimating resolution (width, height).

The default value of chroma_format_idc for 66, 77, 88 (base, main, extended) should be set to 1 (4:2:0).

Height(....) {
...
var cropUnitY uint32
if chromaArrayType == 0 {
cropUnitY = 2 - frameMbsOnlyFlagUint32
} else {
cropUnitY = subHeightC * (2 - frameMbsOnlyFlagUint32)
}
}

Correctly estimates cropUnitY.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3937359) 84.35% compared to head (9f2ad56) 84.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   84.35%   84.24%   -0.11%     
==========================================
  Files          72       72              
  Lines        5580     5580              
==========================================
- Hits         4707     4701       -6     
- Misses        650      652       +2     
- Partials      223      227       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hsnks100]

1080 is the correct value

[aler9]

hello, thanks for spotting the error, i checked the specification (ITU-T H264) and it confirms that when chroma_format_idc is not set, its value shall be 1.