Rework timeline view #120
Merged
Rework timeline view #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this early stage, video output is not integrated yet. I must ensure all the basic functionality is working properly new-timeline-view.mp4 |
… same device have conflicting time spans;
|
Added mobile support 
|
bdlukaa
commented
Jul 19, 2023
| UnityTab.eventsPlayback.index, | ||
| ].contains(tab)) { | ||
| /// On device grid, use landscape | ||
| if ([UnityTab.deviceGrid.index].contains(tab)) { |
There was a problem hiding this comment.
Events Screen is portrait-mode only.
| @@ -27,13 +27,43 @@ import 'package:flutter/material.dart'; | |||
| import 'package:flutter_gen/gen_l10n/app_localizations.dart'; | |||
| import 'package:provider/provider.dart'; | |||
|
|
|||
| Future<Device?> showDeviceSelectorScreen( | |||
There was a problem hiding this comment.
This needs to have some rework to match the overall app design and behavior. It works as it is tho
Comment on lines
40
to
55
| const SubHeader('Time filter', height: 24.0), | ||
| ListTile( | ||
| title: Text(SettingsProvider.instance.dateFormat | ||
| .format(widget.timeline.currentDate)), | ||
| onTap: () async { | ||
| final date = await showDatePicker( | ||
| context: context, | ||
| initialDate: widget.timeline.currentDate, | ||
| firstDate: DateTime(DateTime.now().year), | ||
| lastDate: DateTime.now(), | ||
| initialEntryMode: DatePickerEntryMode.calendarOnly, | ||
| currentDate: widget.timeline.currentDate, | ||
| ); | ||
| debugPrint('date: $date'); | ||
| }, | ||
| ), |
There was a problem hiding this comment.
The time filter doesn't do nothing by now. The backend service doesn't provide a way to fetch events based on the date. Leave it here for future usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeline view displays the events in a timeline of when they happened in the day.
Play/pause with the
SPACEkeyForward/Backward with the arrow keys (15 seconds)
Mute/unmute with the
MkeyReload with the
F5orRkeys