Crosshair separation #209
Open
Crosshair separation #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 10, 2020 16:53
MoonPadUSer
reviewed
Sep 11, 2020
| : POINTER_NONE; | ||
| } | ||
|
|
||
| static void draw_pointer(int w, int h, int pointertype) |
There was a problem hiding this comment.
would be great if you could use ivec2 dims instead of int w, int h
MoonPadUSer
reviewed
Sep 11, 2020
MoonPadUSer
suggested changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mouse cursor and the crosshair are currently treated as the same thing. The same variables are used to store their state and the same functions are used to render them. This was unexpected to me when I found it while trying to make changes to the mouse cursor.
In this pull request they are two different things. This makes it possible to e.g. show the crosshair and cursor in different positions at the same time and therefore it's also possible to keep the crosshair in the background while showing menus.