Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arithmetic exception when fading out plasma #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voidanix
Copy link
Member

@voidanix voidanix commented Jul 27, 2020

When applying plasmapartfade1 to 1, when the particles fade out, the game crashes with an arithmetic exception

Thanks to @robalni for unintentionally finding this

@voidanix voidanix requested review from a user and TheAssassin July 27, 2020 01:22
@voidanix voidanix changed the title Fix arithmetic exception when destructing particles Fix arithmetic exception when fading out plasma Jul 27, 2020
@MoonPadUSer
Copy link
Contributor

does this happen with other weapons too? (would be a little weird otherwise, wouldn't it)

@robalni
Copy link
Contributor

robalni commented Jul 28, 2020

I just tested it and it seems this only happens for plasma.

@ghost
Copy link

ghost commented Jul 28, 2020

Is there is a reason here to think "f == fmax();" everytime?

@voidanix
Copy link
Member Author

voidanix commented Dec 5, 2020

Is there is a reason here to think "f == fmax();" everytime?

no idea, although when replacing rnd() and rndscale() with mt19937 i noticed that the particles never fade away (and the game doesn't crash)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants