Place a ceiling for initial capacity allocated for bytes.Buffer #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Initializing the ceiling to 10MB. This means that at least 10 MB of space is guaranteed if the estimate is larger than that. Any additional space will be allocated on demand. + Intended to address: blevesearch/bleve#1780
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey and
moshaad7
Thejas-bhat
reviewed
Mar 1, 2023
| @@ -32,6 +32,7 @@ import ( | |||
| var NewSegmentBufferNumResultsBump int = 100 | |||
| var NewSegmentBufferNumResultsFactor float64 = 1.0 | |||
| var NewSegmentBufferAvgBytesPerDocFactor float64 = 1.0 | |||
| var MaxSegmentBufferInitialSize int = 10 * 1024 * 1024 // 10MB | |||
There was a problem hiding this comment.
I'm thinking, does it make it sense it make this as a config option in bleve? If we have that, perhaps it would make things a bit more flexible and accommodative based on the use case of application, like the application can run some iterations with different values and set it as a config which works the best for their use case which need not be the optimal value for other use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10 MB of space is guaranteed if the estimate is larger than
that. Any additional space will be allocated on demand.